Skip to content

Conversation

@fealho
Copy link
Member

@fealho fealho commented Nov 13, 2025

CU-86b7b4wnj, Resolve #473

@fealho fealho requested a review from a team as a code owner November 13, 2025 18:05
@fealho fealho requested review from gsheni and removed request for a team November 13, 2025 18:05
@sdv-team
Copy link
Contributor

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.10%. Comparing base (38acb1b) to head (12e161b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdgym/cli/__main__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   76.06%   76.10%   +0.04%     
==========================================
  Files          30       30              
  Lines        2373     2377       +4     
==========================================
+ Hits         1805     1809       +4     
  Misses        568      568              
Flag Coverage Δ
integration 61.66% <70.00%> (+0.02%) ⬆️
unit 70.71% <80.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fealho fealho force-pushed the issue-473-list-datasets branch 2 times, most recently from 8ae0cb9 to 24ccf00 Compare November 13, 2025 18:28
@fealho fealho requested a review from R-Palazzo November 13, 2025 18:37
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Could we add a unit test for list_datasets()?

@fealho fealho force-pushed the issue-473-list-datasets branch from 24ccf00 to bbaee25 Compare November 17, 2025 17:14
@fealho fealho requested a review from R-Palazzo November 17, 2025 17:14
@fealho fealho merged commit c72a368 into main Nov 19, 2025
44 checks passed
@fealho fealho deleted the issue-473-list-datasets branch November 19, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorporate the get_available_datasets functionality into the DatasetExplorer

5 participants